Re: [PATCH] spi: Fix reference count leak in slave_show()

[Greg Kroah-Hartman]

On Wed, Mar 19, 2025 at 11:23:04AM +0800, Miaoqian Lin wrote:
> Fix a reference count leak in slave_show() by properly putting the device
> reference obtained from device_find_any_child().
> 
> Fixes: 6c364062bfed ("spi: core: Add support for registering SPI slave controllers")
> Fixes: c21b0837983d ("spi: Use device_find_any_child() instead of custom approach")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> ---
>  drivers/spi/spi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index a7a4647717d4..ff07c87dbadc 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -2954,9 +2954,13 @@ static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
>  	struct spi_controller *ctlr = container_of(dev, struct spi_controller,
>  						   dev);
>  	struct device *child;
> +	int ret;
>  
>  	child = device_find_any_child(&ctlr->dev);
> -	return sysfs_emit(buf, "%s\n", child ? to_spi_device(child)->modalias : NULL);
> +	ret = sysfs_emit(buf, "%s\n", child ? to_spi_device(child)->modalias : NULL);
> +	put_device(child);
> +
> +	return ret;
>  }
>  
>  static ssize_t slave_store(struct device *dev, struct device_attribute *attr,
> -- 
> 2.39.5 (Apple Git-154)
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot