RE: [PATCH v5 1/3] dt-bindings: hwmon: Add Microchip emc2305 support

[Florin Leotescu (OSS)]

>>On Tue, Mar 18, 2025 at 10:54:42AM +0200, florin.leotescu@xxxxxxxxxxx wrote:
>> From: Florin Leotescu <florin.leotescu@xxxxxxx>
>> 
>> Introduce yaml schema for Microchip emc2305 pwm fan controller.
>> 
>> Signed-off-by: Florin Leotescu <florin.leotescu@xxxxxxx>
>> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
>> ---
>>  .../bindings/hwmon/microchip,emc2305.yaml     | 113 ++++++++++++++++++
>>  1 file changed, 113 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml 
>> b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
>> new file mode 100644
>> index 000000000000..e61ef97e63af
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
>> @@ -0,0 +1,113 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
>> +---
>> +

> No blank line here. Use existing code as template. If you find such code, share so we can fix it.

Thanks!   I will remove it.

Identified similar blank line on the following dt-binding files:

1 adi,ad741x.yaml
2 adi,adm1275.yaml
3 adi,ltc2991.yaml
4 maxim,max20730.yaml
5 maxim,max6639.yaml
6 maxim,max6650.yaml
7 nuvoton,nct6775.yaml
8 nuvoton,nct7363.yaml
9 nuvoton,nct7802.yaml
10 ti,adc128d818.yaml
11 ti,ads7828.yaml
12 ti,ina2xx.yaml
13 ti,lm87.yaml
14 ti,tmp513.yaml
15 ti,tps23861.yaml
16 winbond,w83781d.yaml

>> +$id: http://devicetree.org/schemas/hwmon/microchip,emc2305.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Microchip EMC2305 SMBus compliant PWM fan controller
>> +
>> +maintainers:
>> +  - Michael Shych <michaelsh@xxxxxxxxxx>
>> +
>> +description:
>> +  Microchip EMC2301/2/3/5 pwm controller which supports
>> +  up to five programmable fan control circuits.
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - enum:
>> +          - microchip,emc2305
>> +      - items:
>> +          - enum:
>> +              - microchip,emc2303
>> +              - microchip,emc2302
>> +              - microchip,emc2301
>> +          - const: microchip,emc2305
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  '#address-cells':
>> +    const: 1
>> +
>> +  '#size-cells':
>> +    const: 0
>> +
>> +  '#pwm-cells':
>> +    const: 3
>> +    description: |
>> +      Number of cells in a PWM specifier.
>> +      - cell 0: The PWM frequency
>> +      - cell 1: The PWM polarity: 0 or PWM_POLARITY_INVERTED
>> +      - cell 2: The PWM output config:
>> +           - 0 (Open-Drain)
>> +           - 1 (Push-Pull)
>> +
>> +

> Just one blank line

Ok, I'll remove it. Thank you!

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Florin