Re: [PATCH 1/2] rust: pci: impl Send + Sync for pci::Device
From: Alice Ryhl
Date: Wed Mar 19 2025 - 08:05:48 EST
On Tue, Mar 18, 2025 at 10:29:21PM +0100, Danilo Krummrich wrote:
> Commit 7b948a2af6b5 ("rust: pci: fix unrestricted &mut pci::Device")
> changed the definition of pci::Device and discarded the implicitly
> derived Send and Sync traits.
>
> This isn't required by upstream code yet, and hence did not cause any
> issues. However, it is relied on by upcoming drivers, hence add it back
> in.
>
> Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>
I have a question related to this ... does the Driver trait need to
require T: Send?
The change itself LGTM, so:
Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
Alice