Re: [PATCH] iio: dac: ad3552r-hs: add debugfs reg access

[Nuno Sá]

On Wed, 2025-03-19 at 12:02 +0100, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
> 
> Add debugfs register access.
> 
> Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
> ---

Minor nit you might consider to change if a v2 is needed for some reason...

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>

>  drivers/iio/dac/ad3552r-hs.c | 31 +++++++++++++++++++++++++++++++
>  drivers/iio/dac/ad3552r.h    |  2 ++
>  2 files changed, 33 insertions(+)
> 
> diff --git a/drivers/iio/dac/ad3552r-hs.c b/drivers/iio/dac/ad3552r-hs.c
> index
> cd8dabb60c5548780f0fce5d1b68c494cd71321d..7bb6d8817a545f16de9432526ae28787af1a
> 0146 100644
> --- a/drivers/iio/dac/ad3552r-hs.c
> +++ b/drivers/iio/dac/ad3552r-hs.c
> @@ -7,6 +7,7 @@
>   */
>  
>  #include <linux/bitfield.h>
> +#include <linux/debugfs.h>
>  #include <linux/delay.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/iio/backend.h>
> @@ -56,6 +57,15 @@ struct ad3552r_hs_state {
>  	u32 config_d;
>  };
>  
> +static int ad3552r_hs_get_reg_length(unsigned int reg)
> +{
> +	/*
> +	 * There is no 3 or 4 bytes r/w len possible in HDL, so keeping 2
> +	 * also for the 24bit area.
> +	 */
> +	return (reg > AD3552R_SECONDARY_REGION_START) ? 2 : 1;
> +}
> +

I wonder about the added value of the above. Since it's really only used once, I
would do it inline