Re: [PATCH] arm64: dts: qcom: x1e80100-dell-xps13-9345: Disable PM8010

[Bjorn Andersson]

On Wed, Mar 19, 2025 at 11:06:12AM +0100, Stephan Gerhold wrote:
> On Tue, Mar 18, 2025 at 10:17:02PM -0500, Bjorn Andersson via B4 Relay wrote:
> > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxxxx>
> > 
> > The Qualcomm X Elite reference design uses the PM8010 PMIC for camera
> > use cases, but the Dell XPS13 doesn't. Disable this PMIC to avoid the
> > error in the kernel log caused by an attempt to access it during boot.
> > 
> > Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxxxx>
> 
> Usually we do the opposite: disable nodes by default that may or may not
> be there and enable them where needed. E.g. for the 4 SMB2360 instances
> in x1e80100-pmics.dtsi.
> 
> I think the same approach would also be preferable here. You shouldn't
> get an error in the log just because you didn't go through all of your
> DT includes and checked if you really have all of the components listed
> there. I think it's okay to enable PMICs that are more or less
> guaranteed to be there, but clearly this is not the case for PM8010.
> 

That's reasonable. Have there been reports of this error from anyone
else, or should I go ahead and enable &pm8010 on all !xps13 devices?

Regards,
Bjorn