Re: [PATCH 6.1&6.6 V3 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3

[Jan Stancek]

On Wed, Mar 19, 2025 at 07:13:13AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Mar 19, 2025 at 02:40:31PM +0800, Huacai Chen wrote:
> > From: Jan Stancek <jstancek@xxxxxxxxxx>
> >
> > commit 558bdc45dfb2669e1741384a0c80be9c82fa052c upstream.
> >
> > ENGINE API has been deprecated since OpenSSL version 3.0 [1].
> > Distros have started dropping support from headers and in future
> > it will likely disappear also from library.
> >
> > It has been superseded by the PROVIDER API, so use it instead
> > for OPENSSL MAJOR >= 3.
> >
> > [1] https://github.com/openssl/openssl/blob/master/README-ENGINES.md
> >
> > [jarkko: fixed up alignment issues reported by checkpatch.pl --strict]
> >
> > Signed-off-by: Jan Stancek <jstancek@xxxxxxxxxx>
> > Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> > Tested-by: R Nageswara Sastry <rnsastry@xxxxxxxxxxxxx>
> > Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
> > Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> > ---
> >  certs/extract-cert.c | 103 ++++++++++++++++++++++++++++++-------------
> >  scripts/sign-file.c  |  93 ++++++++++++++++++++++++++------------
> >  2 files changed, 138 insertions(+), 58 deletions(-)
>
> This seems to differ from what is upstream by a lot, please document
> what you changed from it and why when you resend this series again.

Hunks are arranged differently, but code appears to be identical.
When I apply the series to v6.6.83 and compare with upstream I get:

$ git range-diff HEAD~3..HEAD 558bdc45dfb2~3..558bdc45dfb2
1:  02ea9f7368c6 ! 1:  300e6d4116f9 sign-file,extract-cert: move common SSL helper functions to a header
    @@ Metadata
      ## Commit message ##
         sign-file,extract-cert: move common SSL helper functions to a header

    -    commit 300e6d4116f956b035281ec94297dc4dc8d4e1d3 upstream.
    -
         Couple error handling helpers are repeated in both tools, so
         move them to a common header.

    @@ Commit message
         Tested-by: R Nageswara Sastry <rnsastry@xxxxxxxxxxxxx>
         Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
         Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
    -    Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>

      ## MAINTAINERS ##
     @@ MAINTAINERS: S: Maintained
2:  0a81fb059cfd ! 2:  467d60eddf55 sign-file,extract-cert: avoid using deprecated ERR_get_error_line()
    @@ Metadata
      ## Commit message ##
         sign-file,extract-cert: avoid using deprecated ERR_get_error_line()

    -    commit 467d60eddf55588add232feda325da7215ddaf30 upstream.
    -
         ERR_get_error_line() is deprecated since OpenSSL 3.0.

         Use ERR_peek_error_line() instead, and combine display_openssl_errors()
    @@ Commit message
         Tested-by: R Nageswara Sastry <rnsastry@xxxxxxxxxxxxx>
         Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
         Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
    -    Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>

      ## certs/extract-cert.c ##
     @@ certs/extract-cert.c: int main(int argc, char **argv)
3:  0882f379a1f5 ! 3:  558bdc45dfb2 sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3
    @@ Metadata
      ## Commit message ##
         sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3

    -    commit 558bdc45dfb2669e1741384a0c80be9c82fa052c upstream.
    -
         ENGINE API has been deprecated since OpenSSL version 3.0 [1].
         Distros have started dropping support from headers and in future
         it will likely disappear also from library.
    @@ Commit message
         Tested-by: R Nageswara Sastry <rnsastry@xxxxxxxxxxxxx>
         Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
         Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
    -    Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>

      ## certs/extract-cert.c ##
     @@

Regards,
Jan