Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO

From: Sergio Pérez
Date: Wed Mar 19 2025 - 12:27:39 EST

Next message: Greg Kroah-Hartman: "Re: [PATCH 6.1&6.6 V3 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3"
Previous message: Russell King (Oracle): "Re: [net-next PATCH 2/6] net: pcs: Implement OF support for PCS driver"
In reply to: Krzysztof Kozlowski: "Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO"
Next in thread: Sergio Pérez: "Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

El 19/03/2025 a las 9:46, Krzysztof Kozlowski escribió:

On 18/03/2025 18:37, Krzysztof Kozlowski wrote:

I've now run the tool correctly on my patch file and have fixed the
identified issues:
- Removed trailing whitespace
- Fixed lines exceeding 79 characters
- Fixed the inconsistency between the description and example for
reset-gpios
- Modified the existing example instead of adding a new one
- Ensured proper line endings and formatting
- Used proper get_maintainers.pl to include all recipients

Please read the guides carefully. The process is extremely simple as:

git add ...
git commit --signed-off
git format-patch -v3 -2
scripts/chekpatch.pl v3*
scripts/get_maintainers.pl --no-git-fallback v3*
git send-email *

Please read this again. I gave you detailed instruction which you still
decided not to follow. The instructions are quite precise on purpose,
because other method leads to wrong patchset - broken that or other way.

I transcribe exactly the commands I have executed:

$ git add Documentation/devicetree/bindings/iio/light/bh1750.yaml

$ git commit --signed-off

$ git add drivers/iio/light/bh1750.c

$ git commit --signed-off

$ git format-patch -v3 -2

$ scripts/checkpatch.pl v3*
---------------------------------------------------------------
v3-0001-dt-bindings-iio-light-bh1750-Add-reset-gpios-prop.patch
---------------------------------------------------------------
total: 0 errors, 0 warnings, 17 lines checked

v3-0001-dt-bindings-iio-light-bh1750-Add-reset-gpios-prop.patch has no obvious style problems and is ready for submission.
---------------------------------------------------------------
v3-0002-iio-light-bh1750-Add-hardware-reset-support-via-G.patch
---------------------------------------------------------------
total: 0 errors, 0 warnings, 47 lines checked

v3-0002-iio-light-bh1750-Add-hardware-reset-support-via-G.patch has no obvious style problems and is ready for submission.

$ scripts/get_maintainer.pl --no-git-fallback v3*
Tomasz Duszynski <tduszyns@xxxxxxxxx> (maintainer:ROHM BH1750 AMBIENT LIGHT SENSOR DRIVER,in file)
Jonathan Cameron <jic23@xxxxxxxxxx> (maintainer:IIO SUBSYSTEM AND DRIVERS)
Lars-Peter Clausen <lars@xxxxxxxxxx> (reviewer:IIO SUBSYSTEM AND DRIVERS)
Rob Herring <robh@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Conor Dooley <conor+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-iio@xxxxxxxxxxxxxxx (open list:IIO SUBSYSTEM AND DRIVERS)
devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@xxxxxxxxxxxxxxx (open list)

$ git_send_email v3*
v3-0001-dt-bindings-iio-light-bh1750-Add-reset-gpios-prop.patch
v3-0002-iio-light-bh1750-Add-hardware-reset-support-via-G.patch
(mbox) Adding cc: Sergio Perez <sergio@xxxxxxxxxxx> from line 'From: Sergio Perez <sergio@xxxxxxxxxxx>'
(body) Adding cc: Sergio Perez <sergio@xxxxxxxxxxx> from line 'Signed-off-by: Sergio Perez <sergio@xxxxxxxxxxx>'

From: Sergio Perez <sergio@xxxxxxxxxxx>
To: Tomasz Duszynski <tduszyns@xxxxxxxxx>,
        Jonathan Cameron <jic23@xxxxxxxxxx>,
        Lars-Peter Clausen <lars@xxxxxxxxxx>,
        Rob Herring <robh@xxxxxxxxxx>,
        Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>,
        Conor Dooley <conor+dt@xxxxxxxxxx>,
        linux-iio@xxxxxxxxxxxxxxx,
        devicetree@xxxxxxxxxxxxxxx,
        linux-kernel@xxxxxxxxxxxxxxx
Cc: Sergio Perez <sergio@xxxxxxxxxxx>
Subject: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property
Date: Wed, 19 Mar 2025 17:11:16 +0100
Message-ID: <20250319161117.1780-1-sergio@xxxxxxxxxxx>
X-Mailer: git-send-email 2.43.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

    The Cc list above has been expanded by additional
    addresses found in the patch commit message. By default
    send-email prompts before sending whenever this occurs.
    This behavior is controlled by the sendemail.confirm
    configuration setting.

    For additional information, run 'git send-email --help'.
    To retain the current behavior, but squelch this message,
    run 'git config --global sendemail.confirm auto'.

Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y
OK. Log says:
Server: smtp.mail.me.com
MAIL FROM:<sergio@xxxxxxxxxxx>
RCPT TO:<tduszyns@xxxxxxxxx>
RCPT TO:<jic23@xxxxxxxxxx>
RCPT TO:<lars@xxxxxxxxxx>
RCPT TO:<robh@xxxxxxxxxx>
RCPT TO:<krzk+dt@xxxxxxxxxx>
RCPT TO:<conor+dt@xxxxxxxxxx>
RCPT TO:<linux-iio@xxxxxxxxxxxxxxx>
RCPT TO:<devicetree@xxxxxxxxxxxxxxx>
RCPT TO:<linux-kernel@xxxxxxxxxxxxxxx>
RCPT TO:<sergio@xxxxxxxxxxx>
From: Sergio Perez <sergio@xxxxxxxxxxx>
To: Tomasz Duszynski <tduszyns@xxxxxxxxx>,
        Jonathan Cameron <jic23@xxxxxxxxxx>,
        Lars-Peter Clausen <lars@xxxxxxxxxx>,
        Rob Herring <robh@xxxxxxxxxx>,
        Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>,
        Conor Dooley <conor+dt@xxxxxxxxxx>,
        linux-iio@xxxxxxxxxxxxxxx,
        devicetree@xxxxxxxxxxxxxxx,
        linux-kernel@xxxxxxxxxxxxxxx
Cc: Sergio Perez <sergio@xxxxxxxxxxx>
Subject: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property
Date: Wed, 19 Mar 2025 17:11:16 +0100
Message-ID: <20250319161117.1780-1-sergio@xxxxxxxxxxx>
X-Mailer: git-send-email 2.43.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Result: 250
(mbox) Adding cc: Sergio Perez <sergio@xxxxxxxxxxx> from line 'From: Sergio Perez <sergio@xxxxxxxxxxx>'
(body) Adding cc: Sergio Perez <sergio@xxxxxxxxxxx> from line 'Signed-off-by: Sergio Perez <sergio@xxxxxxxxxxx>'

From: Sergio Perez <sergio@xxxxxxxxxxx>
To: Tomasz Duszynski <tduszyns@xxxxxxxxx>,
        Jonathan Cameron <jic23@xxxxxxxxxx>,
        Lars-Peter Clausen <lars@xxxxxxxxxx>,
        Rob Herring <robh@xxxxxxxxxx>,
        Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>,
        Conor Dooley <conor+dt@xxxxxxxxxx>,
        linux-iio@xxxxxxxxxxxxxxx,
        devicetree@xxxxxxxxxxxxxxx,
        linux-kernel@xxxxxxxxxxxxxxx
Cc: Sergio Perez <sergio@xxxxxxxxxxx>
Subject: [PATCH v3 2/2] iio: light: bh1750: Add hardware reset support via GPIO
Date: Wed, 19 Mar 2025 17:11:17 +0100
Message-ID: <20250319161117.1780-2-sergio@xxxxxxxxxxx>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20250319161117.1780-1-sergio@xxxxxxxxxxx>
References: <20250319161117.1780-1-sergio@xxxxxxxxxxx>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y
OK. Log says:
Server: smtp.mail.me.com
MAIL FROM:<sergio@xxxxxxxxxxx>
RCPT TO:<tduszyns@xxxxxxxxx>
RCPT TO:<jic23@xxxxxxxxxx>
RCPT TO:<lars@xxxxxxxxxx>
RCPT TO:<robh@xxxxxxxxxx>
RCPT TO:<krzk+dt@xxxxxxxxxx>
RCPT TO:<conor+dt@xxxxxxxxxx>
RCPT TO:<linux-iio@xxxxxxxxxxxxxxx>
RCPT TO:<devicetree@xxxxxxxxxxxxxxx>
RCPT TO:<linux-kernel@xxxxxxxxxxxxxxx>
RCPT TO:<sergio@xxxxxxxxxxx>
From: Sergio Perez <sergio@xxxxxxxxxxx>
To: Tomasz Duszynski <tduszyns@xxxxxxxxx>,
        Jonathan Cameron <jic23@xxxxxxxxxx>,
        Lars-Peter Clausen <lars@xxxxxxxxxx>,
        Rob Herring <robh@xxxxxxxxxx>,
        Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>,
        Conor Dooley <conor+dt@xxxxxxxxxx>,
        linux-iio@xxxxxxxxxxxxxxx,
        devicetree@xxxxxxxxxxxxxxx,
        linux-kernel@xxxxxxxxxxxxxxx
Cc: Sergio Perez <sergio@xxxxxxxxxxx>
Subject: [PATCH v3 2/2] iio: light: bh1750: Add hardware reset support via GPIO
Date: Wed, 19 Mar 2025 17:11:17 +0100
Message-ID: <20250319161117.1780-2-sergio@xxxxxxxxxxx>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20250319161117.1780-1-sergio@xxxxxxxxxxx>
References: <20250319161117.1780-1-sergio@xxxxxxxxxxx>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Result: 250

(or just use my git_send_email for last two)
(or just use b4 for last four)

The burden of reading the contributing guides is on you. We documented
all this on purpose, so we will not have to repeat this on every email.

[1]
https://github.com/search?q=repo%3Akrzk%2Ftools%20git_send_email&type=code

Best regards,
Krzysztof

Best regards,
Krzysztof

Next message: Greg Kroah-Hartman: "Re: [PATCH 6.1&6.6 V3 3/3] sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3"
Previous message: Russell King (Oracle): "Re: [net-next PATCH 2/6] net: pcs: Implement OF support for PCS driver"
In reply to: Krzysztof Kozlowski: "Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO"
Next in thread: Sergio Pérez: "Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]