Re: [PATCH v4 1/2] wifi: mwifiex: Fix premature release of RF calibration data.
From: Francesco Dolcini
Date: Wed Mar 19 2025 - 12:29:44 EST
Hello Jeff,
On Tue, Mar 18, 2025 at 01:07:38PM +0800, Jeff Chen wrote:
> This patch resolves an issue where RF calibration data was being
> released before the download process. Without this fix, the
> external calibration data file would not be downloaded
> at all.
>
> Fixes: d39fbc88956e ("mwifiex: remove cfg_data construction")
> Signed-off-by: Jeff Chen <jeff.chen_1@xxxxxxx>
The code looks ok to me, however I do not understand the commit you
selected as fixes tag.
>From what I understand releasing the data before using it was done since
the initial commit 388ec385d5ce ("mwifiex: add calibration data download
feature"). What am I missing?
Francesco