Re: [net-next PATCH 2/6] net: pcs: Implement OF support for PCS driver
From: kernel test robot
Date: Wed Mar 19 2025 - 13:08:41 EST
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/net-phylink-reset-PCS-Phylink-double-reference-on-phylink_stop/20250319-080303
base: net-next/main
patch link: https://lore.kernel.org/r/20250318235850.6411-3-ansuelsmth%40gmail.com
patch subject: [net-next PATCH 2/6] net: pcs: Implement OF support for PCS driver
config: i386-buildonly-randconfig-002-20250319 (https://download.01.org/0day-ci/archive/20250320/202503200045.AFf6buBJ-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250320/202503200045.AFf6buBJ-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503200045.AFf6buBJ-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/net/phy/phylink.c:989: warning: Function parameter or struct member 'pcs' not described in 'phylink_pcs_release'
>> drivers/net/phy/phylink.c:989: warning: Excess function parameter 'pl' description in 'phylink_pcs_release'
vim +989 drivers/net/phy/phylink.c
978
979 /**
980 * phylink_pcs_release() - release a PCS
981 * @pl: a pointer to &struct phylink_pcs
982 *
983 * PCS provider can use this to release a PCS from a phylink
984 * instance by stopping the attached netdev. This is only done
985 * if the PCS is actually attached to a phylink, otherwise is
986 * ignored.
987 */
988 void phylink_pcs_release(struct phylink_pcs *pcs)
> 989 {
990 struct phylink *pl = pcs->phylink;
991
992 if (pl) {
993 rtnl_lock();
994 dev_close(pl->netdev);
995 rtnl_unlock();
996 }
997 }
998 EXPORT_SYMBOL_GPL(phylink_pcs_release);
999
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki