Re: [PATCH v3 1/1] scsi: ufs: core: add device level exception support

From: Bart Van Assche
Date: Wed Mar 19 2025 - 13:46:22 EST


On 3/19/25 2:01 AM, Bao D. Nguyen wrote:
On 3/19/2025 12:56 AM, Peter Wang (王信友) wrote:
Could use atomic_t for counter protect?

Are you suggesting to convert the dev_lvl_exception_count type from u32 to atomic_t type? Because the value of dev_lvl_exception_count is returned to the user space via the device_lvl_exception_count_show() using the sysfs_emit() function, keeping the dev_lvl_exception_count as u32 data type probably works better in terms of the format.

I like the suggestion to use atomic_t. atomic_read() can be used in the
sysfs show method.

Thanks,

Bart.