Re: [PATCH v2 03/10] vhost-scsi: Fix vhost_scsi_send_status()

From: Dongli Zhang
Date: Wed Mar 19 2025 - 13:56:49 EST


Hi Jason,

On 3/17/25 5:48 PM, Jason Wang wrote:
> On Tue, Mar 18, 2025 at 7:52 AM Dongli Zhang <dongli.zhang@xxxxxxxxxx> wrote:
>>
>> Although the support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 was
>> signaled by the commit 664ed90e621c ("vhost/scsi: Set
>> VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits"),
>> vhost_scsi_send_bad_target() still assumes the response in a single
>> descriptor.
>>
>> Similar issue in vhost_scsi_send_bad_target() has been fixed in previous
>> commit.
>>
>> Fixes: 3ca51662f818 ("vhost-scsi: Add better resource allocation failure handling")
>
> And
>
> 6dd88fd59da84631b5fe5c8176931c38cfa3b265 ("vhost-scsi: unbreak any
> layout for response")
>

Would suggest add the commit to Fixes?

vhost_scsi_send_status() has been introduced by the most recent patch.

It isn't related to that commit. That commit is to fix
vhost_scsi_complete_cmd_work()

Or would you suggest mention it as part of "Similar issue has been fixed in
previous commit."?

Thank you very much!

Dongli Zhang