Re: [net-next PATCH 5/6] net: pcs: airoha: add PCS driver for Airoha SoC

[kernel test robot]

Hi Christian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/net-phylink-reset-PCS-Phylink-double-reference-on-phylink_stop/20250319-080303
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250318235850.6411-6-ansuelsmth%40gmail.com
patch subject: [net-next PATCH 5/6] net: pcs: airoha: add PCS driver for Airoha SoC
config: x86_64-randconfig-001-20250320 (https://download.01.org/0day-ci/archive/20250320/202503200442.3vYzyScu-lkp@xxxxxxxxx/config)
compiler: clang version 20.1.0 (https://github.com/llvm/llvm-project 24a30daaa559829ad079f2ff7f73eb4e18095f88)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250320/202503200442.3vYzyScu-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503200442.3vYzyScu-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/net/pcs/pcs-airoha.c:2542:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
    2542 |         default:
         |         ^
   drivers/net/pcs/pcs-airoha.c:2542:2: note: insert '__attribute__((fallthrough));' to silence this warning
    2542 |         default:
         |         ^
         |         __attribute__((fallthrough)); 
   drivers/net/pcs/pcs-airoha.c:2542:2: note: insert 'break;' to avoid fall-through
    2542 |         default:
         |         ^
         |         break; 
   1 warning generated.


vim +2542 drivers/net/pcs/pcs-airoha.c

  2521	
  2522	static void airoha_pcs_an_restart(struct phylink_pcs *pcs)
  2523	{
  2524		struct airoha_pcs_priv *priv = phylink_pcs_to_airoha_pcs_port(pcs);
  2525	
  2526		switch (priv->interface) {
  2527		case PHY_INTERFACE_MODE_SGMII:
  2528		case PHY_INTERFACE_MODE_1000BASEX:
  2529		case PHY_INTERFACE_MODE_2500BASEX:
  2530			regmap_set_bits(priv->hsgmii_an, AIROHA_PCS_HSGMII_AN_SGMII_REG_AN_0,
  2531					AIROHA_PCS_HSGMII_AN_SGMII_AN_RESTART);
  2532			udelay(3);
  2533			regmap_clear_bits(priv->hsgmii_an, AIROHA_PCS_HSGMII_AN_SGMII_REG_AN_0,
  2534					  AIROHA_PCS_HSGMII_AN_SGMII_AN_RESTART);
  2535			break;
  2536		case PHY_INTERFACE_MODE_USXGMII:
  2537			regmap_set_bits(priv->usxgmii_pcs, AIROHA_PCS_USXGMII_PCS_AN_CONTROL_0,
  2538					AIROHA_PCS_USXGMII_AN_RESTART);
  2539			udelay(3);
  2540			regmap_clear_bits(priv->usxgmii_pcs, AIROHA_PCS_USXGMII_PCS_AN_CONTROL_0,
  2541					  AIROHA_PCS_USXGMII_AN_RESTART);
> 2542		default:
  2543			return;
  2544		}
  2545	}
  2546	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki