Re: [PATCH v2] perf trace: Implement syscall summary in BPF

[Howard Chu]

Hi Namhyung,

On Wed, Mar 19, 2025 at 3:07 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> Hello Howard,
>
> On Wed, Mar 19, 2025 at 12:00:10PM -0700, Howard Chu wrote:
> > Hello Namhyung,
> >
> > Can you please rebase it? I cannot apply it, getting:
> >
> > perf $ git apply --reject --whitespace=fix
> > ./v2_20250317_namhyung_perf_trace_implement_syscall_summary_in_bpf.mbx
> > Checking patch tools/perf/Documentation/perf-trace.txt...
> > Checking patch tools/perf/Makefile.perf...
> > Hunk #1 succeeded at 1198 (offset -8 lines).
> > Checking patch tools/perf/builtin-trace.c...
> > error: while searching for:
> >         bool       hexret;
> > };
> >
> > enum summary_mode {
> >         SUMMARY__NONE = 0,
> >         SUMMARY__BY_TOTAL,
> >         SUMMARY__BY_THREAD,
> > };
> >
> > struct trace {
> >         struct perf_tool        tool;
> >         struct {
> >
> > error: patch failed: tools/perf/builtin-trace.c:140
>
> Oops, I think I forgot to say it's on top of Ian's change.
> Please try this first.  Sorry for the confusion.
>
> https://lore.kernel.org/r/20250319050741.269828-1-irogers@xxxxxxxxxx

Yep, with Ian's patches it successfully applied. :)

Thanks,
Howard
>
> Thanks,
> Namhyung
>