Re: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property

[Sergio Pérez]

El 19/03/2025 a las 20:12, Krzysztof Kozlowski escribió:
> On 19/03/2025 17:11, Sergio Perez wrote:
> > Some BH1750 sensors require a hardware reset via GPIO before they can
> > be properly detected on the I2C bus. Add a new reset-gpios property
> > to the binding to support this functionality.
> >
> > The reset-gpios property allows specifying a GPIO that will be toggled
> > during driver initialization to reset the sensor.
> >
> > Signed-off-by: Sergio Perez <sergio@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/iio/light/bh1750.yaml | 5 +++++
> >   1 file changed, 5 insertions(+)
> You just sent v3, while v4 was already on the lists, without improving
> and without responding to review.
>
> NAK.
>
> You keep repeating the same mistakes: not reading and responding
> feedback and it is getting tiresome.
I apologize for the confusion with patch versions. You're right that I 
sent v3
after v4 was already on the list. I was trying to follow your exact 
instructions from:
"git add ...
git commit --signed-off
git format-patch -v3 -2
scripts/chekpatch.pl v3*
scripts/get_maintainers.pl --no-git-fallback v3*
git send-email *"

Regarding the binding I've modified for next v5 the YAML description to 
remove "active low" to avoid confusion and modified the example to:

examples:
  - |
    i2c {
      #address-cells = <1>;
      #size-cells = <0>;

      light-sensor@23 {
        compatible = "rohm,bh1750";
        reg = <0x23>;
        reset-gpios = <&gpio2 17 GPIO_ACTIVE_HIGH>;
      };
    };

That is the original version and is the configuration running on my machine.

> Best regards,
> Krzysztof