Re: [PATCH] lib: scatterlist: Fix sg_split_phys to preserve original scatterlist offsets

[Andrew Morton]

On Wed, 19 Mar 2025 16:44:38 +0530 T Pratham <t-pratham@xxxxxx> wrote:

> The split_sg_phys function was incorrectly setting the offsets of all
> scatterlist entries (except the first) to 0. Only the first scatterlist
> entry's offset and length needs to be modified to account for the skip.
> Setting the rest entries' offsets to 0 could lead to incorrect data
> access.
> 
> This patch removes the offending code, ensuring that the page offsets
> in the input scatterlist are preserved in the output scatterlist.

Is this merely from code inspection, or is this issues known to have
observable runtime effects?

If the latter, please provide a complete description.

>
> ...
>
> --- a/lib/sg_split.c
> +++ b/lib/sg_split.c
> @@ -88,8 +88,6 @@ static void sg_split_phys(struct sg_splitter *splitters, const int nb_splits)
>  			if (!j) {
>  				out_sg->offset += split->skip_sg0;
>  				out_sg->length -= split->skip_sg0;
> -			} else {
> -				out_sg->offset = 0;
>  			}
>  			sg_dma_address(out_sg) = 0;
>  			sg_dma_len(out_sg) = 0;
> -- 
> 2.34.1