[PATCH v5 10/17] rust: workqueue: replace `raw_get` with pointer cast

From: Antonio Hickey
Date: Wed Mar 19 2025 - 22:11:16 EST


Now that `Work` is initialized via `pin-init`, the `work` field
is always used. This allows us to replace the use of unsafe
`Opaque::raw_get` with direct pointer casting.

Suggested-by: Boqun Feng <boqun.feng@xxxxxxxxx>
Link: https://lore.kernel.org/all/20250316061429.817126-1-contact@xxxxxxxxxxxxxxxxx/T/#mc7a4757e8c132f84228b728c7d123d73841501d6
Signed-off-by: Antonio Hickey <contact@xxxxxxxxxxxxxxxxx>
---
rust/kernel/workqueue.rs | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/rust/kernel/workqueue.rs b/rust/kernel/workqueue.rs
index 4e27df324d26..5cc259c1e502 100644
--- a/rust/kernel/workqueue.rs
+++ b/rust/kernel/workqueue.rs
@@ -399,12 +399,8 @@ pub fn new(name: &'static CStr, key: &'static LockClassKey) -> impl PinInit<Self
/// need not be initialized.)
#[inline]
pub unsafe fn raw_get(ptr: *const Self) -> *mut bindings::work_struct {
- // SAFETY: The caller promises that the pointer is aligned and not dangling.
- //
- // A pointer cast would also be ok due to `#[repr(transparent)]`. We use
- // `&raw const (*ptr).work` so that the compiler does not complain that the
- // `work` field is unused.
- unsafe { Opaque::raw_get(&raw const (*ptr).work) }
+ // CAST: `Work` is transparent to `bindings::work_struct`.
+ ptr.cast_mut().cast()
}
}