Re: [PATCH v8 5/5] arm64: dts: mediatek: mt8365: Add support for camera

[CK Hu (胡俊光)]

On Wed, 2025-01-22 at 14:59 +0100, Julien Stephan wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> Add base support for cameras for mt8365 platforms. This requires nodes
> for the sensor interface, camsv, and CSI receivers.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
> ---

[snip]

> +
> +               camsv1: camsv@15050000 {
> +                       compatible = "mediatek,mt8365-camsv";
> +                       reg = <0 0x15050000 0 0x0040>,
> +                             <0 0x15050208 0 0x0020>,
> +                             <0 0x15050400 0 0x0100>;
> +                       interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_LOW>;
> +                       clocks = <&camsys CLK_CAM>,
> +                                <&camsys CLK_CAMTG>,
> +                                <&camsys CLK_CAMSV0>;
> +                       clock-names = "cam", "camtg", "camsv";
> +                       iommus = <&iommu M4U_PORT_CAM_IMGO>;
> +                       mediatek,larb = <&larb2>;

binding document has no larb property, drop it.

> +                       power-domains = <&spm MT8365_POWER_DOMAIN_CAM>;
> +                       status = "disabled";
> +
> +                       ports {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               port@0 {
> +                                       reg = <0>;
> +                                       camsv1_endpoint: endpoint {
> +                                               remote-endpoint = <&seninf_camsv1_endpoint>;
> +                                       };
> +                               };
> +                       };
> +               };
> +
> +               camsv2: camsv@15050800 {
> +                       compatible = "mediatek,mt8365-camsv";
> +                       reg = <0 0x15050800 0 0x0040>,
> +                             <0 0x15050228 0 0x0020>,
> +                             <0 0x15050c00 0 0x0100>;
> +                       interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_LOW>;
> +                       clocks = <&camsys CLK_CAM>,
> +                                <&camsys CLK_CAMTG>,
> +                                <&camsys CLK_CAMSV1>;
> +                       clock-names = "cam", "camtg", "camsv";
> +                       iommus = <&iommu M4U_PORT_CAM_IMGO>;
> +                       mediatek,larb = <&larb2>;

Ditto.

Regards,
CK

> +                       power-domains = <&spm MT8365_POWER_DOMAIN_CAM>;
> +                       status = "disabled";
> +
> +                       ports {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               port@0 {
> +                                       reg = <0>;
> +                                       camsv2_endpoint: endpoint {
> +                                               remote-endpoint = <&seninf_camsv2_endpoint>;
> +                                       };
> +                               };
> +                       };
> +               };
> +
>                 vdecsys: syscon@16000000 {
>                         compatible = "mediatek,mt8365-vdecsys", "syscon";
>                         reg = <0 0x16000000 0 0x1000>;
> 
> --
> 2.47.1
> 
>