Re: [PATCH next] pinctrl: tegra: Fix off by one in tegra_pinctrl_get_group()

From: Linus Walleij
Date: Thu Mar 20 2025 - 04:15:07 EST


On Wed, Mar 19, 2025 at 8:05 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> This should be >= pmx->soc->ngroups instead of > to avoid an out of
> bounds access. The pmx->soc->groups[] array is allocated in
> tegra_pinctrl_probe().
>
> Fixes: c12bfa0fee65 ("pinctrl-tegra: Restore SFSEL bit when freeing pins")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks Dan, excellent find.

Patch applied!

Yours,
Linus Walleij