Re: [PATCH 2/4] net: ch9200: remove extraneous return in control_write() to propagate failures

From: Simon Horman
Date: Thu Mar 20 2025 - 10:03:13 EST


On Wed, Mar 19, 2025 at 11:21:54AM +0000, Qasim Ijaz wrote:
> The control_write() function sets err to -EINVAL however there
> is an incorrectly placed 'return 0' statement after it which stops
> the propogation of the error.
>
> Fix this issue by removing the 'return 0'.
>
> Fixes: 4a476bd6d1d9 ("usbnet: New driver for QinHeng CH9200 devices")
> Signed-off-by: Qasim Ijaz <qasdev00@xxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>