Re: [PATCH -next 2/2] staging: gpib: Remove unnecessary print function dev_err()

From: Greg KH
Date: Thu Mar 20 2025 - 10:03:28 EST


On Wed, Feb 26, 2025 at 02:07:35PM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/staging/gpib/fmh_gpib/fmh_gpib.c:1426:2-9: line 1426 is redundant because platform_get_irq() already prints an error.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19059
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

You have 2 different patches here, yet the identical subject line. I
just caught this after I added it to my staging-testing branch, so I'll
go drop it from there now and wait for a v2 series.

thanks,

greg k-h