Re: [PATCH] [PATCH v2] staging: sm750fb: Make g_fbmode truly constant

[Greg KH]

On Sun, Feb 23, 2025 at 01:45:14AM +0530, Madhur Kumar wrote:
> Declare g_fbmode as a pointer to constant data. This ensures that both
> array and its element are immutable.
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Madhur Kumar <madhurkumar004@xxxxxxxxx>
> ---
> Changes in v2:
> - Added commit message
> ---
>  drivers/staging/sm750fb/sm750.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 04c1b32a2..aa154032f 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -33,7 +33,7 @@
>  static int g_hwcursor = 1;
>  static int g_noaccel;
>  static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};

How did you test this?  It totally breaks the build :(