Re: [PATCH net-next v09 1/1] hinic3: module initialization and tx/rx logic
From: Simon Horman
Date: Thu Mar 20 2025 - 11:03:36 EST
On Mon, Mar 17, 2025 at 11:40:39AM +0200, Gur Stavi wrote:
> From: Fan Gong <gongfan1@xxxxxxxxxx>
>
> This is [1/3] part of hinic3 Ethernet driver initial submission.
> With this patch hinic3 is a valid kernel module but non-functional
> driver.
>
> The driver parts contained in this patch:
> Module initialization.
> PCI driver registration but with empty id_table.
> Auxiliary driver registration.
> Net device_ops registration but open/stop are empty stubs.
> tx/rx logic.
>
> All major data structures of the driver are fully introduced with the
> code that uses them but without their initialization code that requires
> management interface with the hw.
>
> Co-developed-by: Xin Guo <guoxin09@xxxxxxxxxx>
> Signed-off-by: Xin Guo <guoxin09@xxxxxxxxxx>
> Signed-off-by: Fan Gong <gongfan1@xxxxxxxxxx>
> Co-developed-by: Gur Stavi <gur.stavi@xxxxxxxxxx>
> Signed-off-by: Gur Stavi <gur.stavi@xxxxxxxxxx>
Thanks for addressing my feedback on v8.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>