Re: [PATCH 1/6] sched_ext: idle: Extend topology optimizations to all tasks
From: Andrea Righi
Date: Thu Mar 20 2025 - 18:09:13 EST
Hi Tejun,
On Thu, Mar 20, 2025 at 06:49:47AM -1000, Tejun Heo wrote:
> On Thu, Mar 20, 2025 at 08:36:41AM +0100, Andrea Righi wrote:
> > +static const struct cpumask *task_cpumask(const struct task_struct *p, const struct cpumask *cpus,
> > + struct cpumask *local_cpus)
> > +{
> > + /*
> > + * If the task is allowed to run on all CPUs, simply use the
> > + * architecture's cpumask directly. Otherwise, compute the
> > + * intersection of the architecture's cpumask and the task's
> > + * allowed cpumask.
> > + */
> > + if (!cpus || p->nr_cpus_allowed >= num_possible_cpus() ||
> > + cpumask_subset(cpus, p->cpus_ptr))
> > + return cpus;
> > +
> > + if (!cpumask_equal(cpus, p->cpus_ptr) &&
>
> Weren't we talkign about removing this test?
sorry, it's actually removed in PATCH 3/6, but I'll clean it up also in
this one.
Thanks,
-Andrea
>
> Thanks.
>
> --
> tejun