[PATCH v2 2/6] x86/microcode/intel: Define staging state struct
From: Chang S. Bae
Date: Thu Mar 20 2025 - 19:41:35 EST
To facilitate a structured staging handler, a set of functions will be
introduced. Define staging_state struct to simplify function prototypes
by consolidating relevant data, instead of passing multiple local
variables.
Signed-off-by: Chang S. Bae <chang.seok.bae@xxxxxxxxx>
---
V1 -> V2: New patch
In the previous version, local variables were used to track state values,
with the intention of improving readability by explicitly passing them
between functions. However, given feedbacks, introducing a dedicated data
structure looks to provide a benefit by simplifying the main loop, which
is now prioritized.
---
arch/x86/kernel/cpu/microcode/intel.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index 819199bc0119..57ed5d414cd1 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -54,6 +54,27 @@ struct extended_sigtable {
struct extended_signature sigs[];
};
+/**
+ * struct staging_state - Tracks the current staging process state
+ *
+ * @mmio_base: MMIO base address for staging
+ * @ucode_ptr: Pointer to the microcode image
+ * @ucode_len: Total size of the microcode image
+ * @chunk_size: Size of each data piece
+ * @bytes_sent: Total bytes transmitted so far
+ * @offset: Current offset in the microcode image
+ * @state: Current state of the staging process
+ */
+struct staging_state {
+ void __iomem *mmio_base;
+ void *ucode_ptr;
+ unsigned int ucode_len;
+ unsigned int chunk_size;
+ unsigned int bytes_sent;
+ unsigned int offset;
+ enum ucode_state state;
+};
+
#define DEFAULT_UCODE_TOTALSIZE (DEFAULT_UCODE_DATASIZE + MC_HEADER_SIZE)
#define EXT_HEADER_SIZE (sizeof(struct extended_sigtable))
#define EXT_SIGNATURE_SIZE (sizeof(struct extended_signature))
--
2.45.2