Re: [PATCH v3 08/18] nvmet-fcloop: add missing fcloop_callback_host_done

From: Christoph Hellwig
Date: Fri Mar 21 2025 - 02:13:05 EST


On Tue, Mar 18, 2025 at 11:40:02AM +0100, Daniel Wagner wrote:
> - if (!tfcp_req)
> + if (!tfcp_req) {
> /* abort has already been called */
> + fcloop_call_host_done(fcpreq, tfcp_req, -ECANCELED);
> return;
> + }
>
> /* break initiator/target relationship for io */
> spin_lock_irqsave(&tfcp_req->reqlock, flags);
> @@ -982,6 +984,7 @@ fcloop_fcp_abort(struct nvme_fc_local_port *localport,
> break;
> default:
> spin_unlock_irqrestore(&tfcp_req->reqlock, flags);
> + fcloop_call_host_done(fcpreq, tfcp_req, -ECANCELED);

Maybe share this using a goto?