Re: [PATCH v15 02/11] rust: add dma coherent allocator abstraction.
From: Andreas Hindborg
Date: Fri Mar 21 2025 - 02:56:33 EST
"Miguel Ojeda" <miguel.ojeda.sandonis@xxxxxxxxx> writes:
> On Tue, Mar 18, 2025 at 2:13 PM Andreas Hindborg <a.hindborg@xxxxxxxxxx> wrote:
>>
>> The wording of in the other doc comments is different than this one and
>> the two next ones. Consider aligning them:
>>
>> Hints the DMA-mapping subsystem that ...
>>
>> Tells the DMA-mapping subsystem ...
>>
>> Indicates that the buffer ...
>
> These come from the C side and are copy-pasted, so I suspect that was
> the reason -- they may want to have them in sync, so I didn't touch
> them.
Since this particular doc discussion is about wording and not semantics,
I won't object too much. However, writing the docs for Rust is a very
good chance to get _better_ docs and in general I would encourage taking
advantage of that.
Best regards,
Andreas Hindborg