Re: [PATCH v3 3/3] x86: Zap TOP_OF_KERNEL_STACK_PADDING on x86_64
From: H. Peter Anvin
Date: Fri Mar 21 2025 - 04:15:59 EST
On March 20, 2025 10:47:25 PM PDT, Xin Li <xin@xxxxxxxxx> wrote:
>On 3/19/2025 12:17 PM, Brian Gerst wrote:
>> I'm not sure it's worth fully removing TOP_OF_KERNEL_STACK_PADDING for
>> 64-bit if it results in needing separate definitions of
>> task_top_of_stack(). Leaving it at zero is fine. The other changes
>> are fine though.
>
>Let's leave it to x86 maintainers ;-)
>
>But to me, TOP_OF_KERNEL_STACK_PADDING no longer makes sense on 64-bit,
>and it makes it simpler to remove it. On the other side, 32-bit is to
>be zapped...
>
>Thanks!
> Xin
>
For what it's worth, it was there as 0 before the FRED changes, so ...