Re: [PATCH net v2] bonding: check xdp prog when set bond mode

[Jussi Maki]

On Fri, Mar 21, 2025 at 5:38 AM Wang Liang <wangliang74@xxxxxxxxxx> wrote:
>
> Following operations can trigger a warning[1]:
>
>     ip netns add ns1
>     ip netns exec ns1 ip link add bond0 type bond mode balance-rr
>     ip netns exec ns1 ip link set dev bond0 xdp obj af_xdp_kern.o sec xdp
>     ip netns exec ns1 ip link set bond0 type bond mode broadcast
>     ip netns del ns1
>
> When delete the namespace, dev_xdp_uninstall() is called to remove xdp
> program on bond dev, and bond_xdp_set() will check the bond mode. If bond
> mode is changed after attaching xdp program, the warning may occur.
>
> Some bond modes (broadcast, etc.) do not support native xdp. Set bond mode
> with xdp program attached is not good. Add check for xdp program when set
> bond mode.

Looks reasonable to me. Thanks!

Acked-by: Jussi Maki <joamaki@xxxxxxxxx>