Re: [PATCH v2 3/8] drivers/perf: hisi: Use ACPI driver_data to retrieve SLLC PMU information

From: Jonathan Cameron
Date: Fri Mar 21 2025 - 07:14:00 EST


On Fri, 21 Mar 2025 15:38:41 +0800
Yicong Yang <yangyicong@xxxxxxxxxx> wrote:

> From: Junhao He <hejunhao3@xxxxxxxxxx>
>
> Make use of struct acpi_device_id::driver_data for version specific
> information rather than judge the version register. This will help
> to simplify the probe process and also a bit easier for extension.
>
> Factor out SLLC register definition to struct hisi_sllc_pmu_regs.
> No functional changes intended.
>
> Signed-off-by: Junhao He <hejunhao3@xxxxxxxxxx>
> Signed-off-by: Yicong Yang <yangyicong@xxxxxxxxxxxxx>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>