Re: [PATCH v6 1/1] MIPS: Fix idle VS timer enqueue
From: Maciej W. Rozycki
Date: Fri Mar 21 2025 - 07:55:54 EST
On Fri, 21 Mar 2025, Thomas Bogendoerfer wrote:
> > > > + /* Check idle interrupt region size. */
> > > > + .ifne __r4k_wait_exit - __r4k_wait - 36
> > >
> > > I have to say, that I prefer my .if statement, since this clearly spells out
> > > the comparision in the expression. Is there a reason for your version ?
> >
> > Sure, let's keep your version.
> > Can we use the "error" message above? (""Idle interrupt region size
> > mismatch: expected 36 bytes."").
> > Or at least something similar, I think it is easier to understand the
> > reason for the error. What do you think?
>
> the error message works for me :-)
I'm glad seeing this being sorted properly, thank you!
Maciej