[PATCH] ASoC: SDCA: Correct handling of selected mode DisCo property
From: Charles Keepax
Date: Fri Mar 21 2025 - 09:56:44 EST
mipi-sdca-ge-selectedmode-controls-affected is actually required by the
specification so the code should return an error if it is missing.
Reported-by: Maciej Strozek <mstrozek@xxxxxxxxxxxxxxxxxxxxx>
Fixes: d1cd13f80dc6 ("ASoC: SDCA: Add support for GE Entity properties")
Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
---
sound/soc/sdca/sdca_functions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sdca/sdca_functions.c b/sound/soc/sdca/sdca_functions.c
index c8efdc5301b53..493f390f087ad 100644
--- a/sound/soc/sdca/sdca_functions.c
+++ b/sound/soc/sdca/sdca_functions.c
@@ -1159,7 +1159,7 @@ static int find_sdca_entity_ge(struct device *dev,
num_affected = fwnode_property_count_u8(entity_node,
"mipi-sdca-ge-selectedmode-controls-affected");
- if (!num_affected || num_affected == -EINVAL) {
+ if (!num_affected) {
return 0;
} else if (num_affected < 0) {
dev_err(dev, "%s: failed to read affected controls: %d\n",
--
2.39.5