Re: [PATCH v2 0/7] Additional methods for Vec
From: Tamir Duberstein
Date: Fri Mar 21 2025 - 11:48:26 EST
On Fri, Mar 21, 2025 at 8:10 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
>
> This adds various Vec methods. Some of them are needed by Rust Binder,
> and others are needed in other places. Each commit explains where it is
> needed.
>
> I'm not sure what we concluded on the set_len / dec_len changes, so I
> don't depend on that series for now.
>
> This series is based on top of Vec::truncate from
> https://lore.kernel.org/rust-for-linux/20250316111644.154602-1-andrewjballance@xxxxxxxxx/
>
> Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> ---
> Changes in v2:
> - Add two more methods that I needed.
> - Introduce some uses of set_len.
> - Add example to retain.
> - Simplify pop.
> - Adjust 11 to 10 in push_within_capacity example.
> - Link to v1: https://lore.kernel.org/r/20250320-vec-methods-v1-0-7dff5cf25fe8@xxxxxxxxxx
>
> ---
> Alice Ryhl (7):
> rust: alloc: add Vec::clear
> rust: alloc: add Vec::pop
> rust: alloc: add Vec::push_within_capacity
> rust: alloc: add Vec::drain_all
> rust: alloc: add Vec::retain
> rust: alloc: add Vec::remove
> rust: alloc: add Vec::insert_within_capacity
>
> rust/kernel/alloc/kvec.rs | 202 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 202 insertions(+)
> ---
> base-commit: a337a03281efc4553191b432d757d4c04884bf4c
> change-id: 20250320-vec-methods-adfa41e55311
I think this doesn't specify the dependencies properly. The
base-commit looks to be
https://lore.kernel.org/all/20250316111644.154602-3-andrewjballance@xxxxxxxxx/
locally applied. This prevents `b4 shazam` from working with this
series.