Re: [PATCH] wifi: mt76: mt7996: remove duplicate check in mt7996_mcu_sta_mld_setup_tlv()

From: Lorenzo Bianconi
Date: Fri Mar 21 2025 - 11:55:34 EST


> The "msta_link" pointer has two NULL checks. Delete the second check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 3 ---
> 1 file changed, 3 deletions(-)
>

Acked-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>

> diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
> index ddd555942c73..03539e20f5c5 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
> @@ -2242,9 +2242,6 @@ mt7996_mcu_sta_mld_setup_tlv(struct mt7996_dev *dev, struct sk_buff *skb,
> if (!link)
> continue;
>
> - if (!msta_link)
> - continue;
> -
> mld_setup_link->wcid = cpu_to_le16(msta_link->wcid.idx);
> mld_setup_link->bss_idx = link->mt76.idx;
> mld_setup_link++;
> --
> 2.47.2
>

Attachment: signature.asc
Description: PGP signature