Re: [PATCH net-next 1/2] r8169: enable RTL8168H/RTL8168EP/RTL8168FP ASPM support
From: Paolo Abeni
Date: Fri Mar 21 2025 - 13:18:02 EST
On 3/14/25 8:50 AM, ChunHao Lin wrote:
> This patch will enable RTL8168H/RTL8168EP/RTL8168FP ASPM support on
> the platforms that have tested with ASPM enabled.
>
> Signed-off-by: ChunHao Lin <hau@xxxxxxxxxxx>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index b18daeeda40d..3c663fca07d3 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5398,7 +5398,7 @@ static void rtl_init_mac_address(struct rtl8169_private *tp)
> /* register is set if system vendor successfully tested ASPM 1.2 */
> static bool rtl_aspm_is_safe(struct rtl8169_private *tp)
> {
> - if (tp->mac_version >= RTL_GIGA_MAC_VER_61 &&
> + if (tp->mac_version >= RTL_GIGA_MAC_VER_46 &&
> r8168_mac_ocp_read(tp, 0xc0b2) & 0xf)
> return true;
>
FTR 2 copies of this patch and the cover letter landed on the ML
confusing patchwork. Please avoid duplicate messages in future submissions.
Thanks,
Paolo