Re: [PATCH v2 2/6] x86/hyperv: Use hv_hvcall_*() to set up hypercall arguments -- part 1

From: Nuno Das Neves
Date: Fri Mar 21 2025 - 15:22:13 EST


On 3/12/2025 11:19 PM, mhkelley58@xxxxxxxxx wrote:
> From: Michael Kelley <mhklinux@xxxxxxxxxxx>
>
> Update hypercall call sites to use the new hv_hvcall_*() functions
> to set up hypercall arguments. Since these functions zero the
> fixed portion of input memory, remove now redundant calls to memset()
> and explicit zero'ing of input fields.
>
> Signed-off-by: Michael Kelley <mhklinux@xxxxxxxxxxx>
> ---
>
> Notes:
> Changes in v2:
> * Fixed get_vtl() and hv_vtl_apicid_to_vp_id() to properly treat the input
> and output arguments as arrays [Nuno Das Neves]
> * Enhanced __send_ipi_mask_ex() and hv_map_interrupt() to check the number
> of computed banks in the hv_vpset against the batch_size. Since an
> hv_vpset currently represents a maximum of 4096 CPUs, the hv_vpset size
> does not exceed 512 bytes and there should always be sufficent space. But
> do the check just in case something changes. [Nuno Das Neves]
>
> arch/x86/hyperv/hv_apic.c | 10 ++++------
> arch/x86/hyperv/hv_init.c | 6 ++----
> arch/x86/hyperv/hv_vtl.c | 9 +++------
> arch/x86/hyperv/irqdomain.c | 17 ++++++++++-------
> 4 files changed, 19 insertions(+), 23 deletions(-)
>

Reviewed-by: Nuno Das Neves <nunodasneves@xxxxxxxxxxxxxxxxxxx>