Re: [PATCH v1 6/8] dt-bindings: mips: Add EcoNet platform binding

[Krzysztof Kozlowski]

On 21/03/2025 14:46, Caleb James DeLisle wrote:
> Document the top-level device tree binding for EcoNet MIPS-based SoCs.
> 
> Signed-off-by: Caleb James DeLisle <cjd@xxxxxxxx>
> ---
>  .../devicetree/bindings/mips/econet.yaml      | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mips/econet.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mips/econet.yaml b/Documentation/devicetree/bindings/mips/econet.yaml
> new file mode 100644
> index 000000000000..44da78dc1e29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mips/econet.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mips/econet.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: EcoNet MIPS SoCs
> +
> +maintainers:
> +  - Caleb James DeLisle <cjd@xxxxxxxx>
> +
> +description:
> +  Boards with an EcoNet SoC shall have the following properties.

Drop description, useless and not even correct.

> +
> +properties:
> +  $nodename:
> +    const: '/'
> +
> +  compatible:
> +    oneOf:
> +      - description: Boards with EcoNet EN751221 family SoC
> +        items:
> +          - const: econet,en751221

That's a soc. You need board compatible as well. Look at other
upstreamed code.



Best regards,
Krzysztof