Re: [PATCH v3 5/7] x86/Kconfig: Document CONFIG_PCI_MMCONFIG
From: Ingo Molnar
Date: Sat Mar 22 2025 - 03:11:35 EST
* David Heidelberg via B4 Relay <devnull+david.ixit.cz@xxxxxxxxxx> wrote:
> From: Mateusz Jończyk <mat.jonczyk@xxxxx>
>
> This configuration option had no help text, so add it.
>
> CONFIG_EXPERT is enabled on some distribution kernels, so people using a
> distribution kernel's configuration as a starting point will see this
> option.
>
> Signed-off-by: Mateusz Jończyk <mat.jonczyk@xxxxx>
> Signed-off-by: David Heideberg <david@xxxxxxx>
> ---
> arch/x86/Kconfig | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index fbc9ba30fd1cbfb574399a0632b9f77876ba84a8..64a1e00619df95f559488e3004558a7b0f653df3 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2914,6 +2914,19 @@ config PCI_MMCONFIG
> default y
> depends on PCI && (ACPI || JAILHOUSE_GUEST)
> depends on X86_64 || (PCI_GOANY || PCI_GOMMCONFIG)
> + help
> + Add support for accessing the PCI configuration space as a memory
> + mapped area. It is the recommended method if the system supports
> + this (it must have PCI Express and ACPI for it to be available).
> +
> + In the unlikely case that enabling this configuration option causes
> + problems, the mechanism can be switched off with the 'pci=nommconf'
> + command line parameter.
> +
> + Say 'n' only if you are sure that your platform does not support this
> + access method or you have problems caused by it.
> +
> + Say 'y' otherwise.
For future reference, the canonical incantantion in Kconfig lore is:
Say Y otherwise.
I have fixed it up in this commit.
Thanks,
Ingo