Re: [PATCH 13/13] objtool: Add CONFIG_OBJTOOL_WERROR

[Josh Poimboeuf]

On Mon, Mar 17, 2025 at 03:14:25PM +0100, Miroslav Benes wrote:
> On Fri, 14 Mar 2025, Josh Poimboeuf wrote:
> 
> > Objtool warnings can be indicative of crashes, broken live patching, or
> > even boot failures.  Ignoring them is not recommended.
> > 
> > Add CONFIG_OBJTOOL_WERROR to upgrade objtool warnings to errors by
> > enabling the objtool --Werror option.  Also set --backtrace to print the
> > branches leading up to the warning, which can help considerably when
> > debugging certain warnings.
> > 
> > To avoid breaking bots too badly for now, make it the default for real
> > world builds only (!COMPILE_TEST).
> > 
> > Co-developed-by: Brendan Jackman <jackmanb@xxxxxxxxxx>
> > Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> 
> Brendan's SoB missing.
> 
> With 'default y' being present or not
> 
> Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>

Miroslav and Brendan, thanks for the reviews.

This was merged with a quickness, so I wasn't able to post a v2 to
update the commit logs.  However I will be posting some patches soon to
address the other comments, along with a bunch of fixes.

-- 
Josh