Re: [PATCH v2 2/2] iio: adc: adding support for PAC194X
From: Dan Carpenter
Date: Mon Mar 24 2025 - 01:57:16 EST
Hi,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/marius-cristea-microchip-com/dt-bindings-iio-adc-adding-support-for-PAC194X/20250317-171150
base: 577a66e2e634f712384c57a98f504c44ea4b47da
patch link: https://lore.kernel.org/r/20250317090803.30003-3-marius.cristea%40microchip.com
patch subject: [PATCH v2 2/2] iio: adc: adding support for PAC194X
config: arm64-randconfig-r071-20250322 (https://download.01.org/0day-ci/archive/20250323/202503230315.DVkVt7Ag-lkp@xxxxxxxxx/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project c2692afc0a92cd5da140dfcdfff7818a5b8ce997)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202503230315.DVkVt7Ag-lkp@xxxxxxxxx/
smatch warnings:
drivers/iio/adc/pac1944.c:1707 pac1944_retrieve_data() error: uninitialized symbol 'ret'.
drivers/iio/adc/pac1944.c:2463 pac1944_write_thresh() warn: inconsistent indenting
vim +/ret +1707 drivers/iio/adc/pac1944.c
e227d6e5b38646 Marius Cristea 2025-03-17 1681 static int pac1944_retrieve_data(struct pac1944_chip_info *info, u32 wait_time)
e227d6e5b38646 Marius Cristea 2025-03-17 1682 {
e227d6e5b38646 Marius Cristea 2025-03-17 1683 int ret;
e227d6e5b38646 Marius Cristea 2025-03-17 1684
e227d6e5b38646 Marius Cristea 2025-03-17 1685 /*
e227d6e5b38646 Marius Cristea 2025-03-17 1686 * Check if the minimal elapsed time has passed and if so,
e227d6e5b38646 Marius Cristea 2025-03-17 1687 * re-read the chip, otherwise the cached info is just fine
e227d6e5b38646 Marius Cristea 2025-03-17 1688 */
e227d6e5b38646 Marius Cristea 2025-03-17 1689 if (time_after(jiffies, info->chip_reg_data.jiffies_tstamp +
e227d6e5b38646 Marius Cristea 2025-03-17 1690 msecs_to_jiffies(PAC1944_MIN_POLLING_TIME_MS))) {
e227d6e5b38646 Marius Cristea 2025-03-17 1691 /*
e227d6e5b38646 Marius Cristea 2025-03-17 1692 * We need to re-read the chip values
e227d6e5b38646 Marius Cristea 2025-03-17 1693 * call the pac1944_reg_snapshot
e227d6e5b38646 Marius Cristea 2025-03-17 1694 */
e227d6e5b38646 Marius Cristea 2025-03-17 1695 ret = pac1944_reg_snapshot(info, true,
e227d6e5b38646 Marius Cristea 2025-03-17 1696 PAC1944_REFRESH_REG_ADDR,
e227d6e5b38646 Marius Cristea 2025-03-17 1697 wait_time);
e227d6e5b38646 Marius Cristea 2025-03-17 1698 /*
e227d6e5b38646 Marius Cristea 2025-03-17 1699 * Re-schedule the work for the read registers timeout
e227d6e5b38646 Marius Cristea 2025-03-17 1700 * (to prevent chip regs saturation)
e227d6e5b38646 Marius Cristea 2025-03-17 1701 */
e227d6e5b38646 Marius Cristea 2025-03-17 1702 cancel_delayed_work_sync(&info->work_chip_rfsh);
e227d6e5b38646 Marius Cristea 2025-03-17 1703 schedule_delayed_work(&info->work_chip_rfsh,
e227d6e5b38646 Marius Cristea 2025-03-17 1704 msecs_to_jiffies(PAC1944_MAX_RFSH_LIMIT_MS));
e227d6e5b38646 Marius Cristea 2025-03-17 1705 }
ret isn't initialized on else path.
e227d6e5b38646 Marius Cristea 2025-03-17 1706
e227d6e5b38646 Marius Cristea 2025-03-17 @1707 return ret;
e227d6e5b38646 Marius Cristea 2025-03-17 1708 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki