Re: [PATCH v5 2/2] arm64: dts: amlogic: add support for xiaomi-aquaman/Mi TV Stick

[Neil Armstrong]

On 19/03/2025 23:36, Martin Blumenstingl wrote:
> Hello,
>
> thanks for your contribution and sorry for the late reply!
>
> On Wed, Mar 19, 2025 at 8:02 PM Ferass El Hafidi
> <funderscore@xxxxxxxxxxxxxxxx> wrote:
> [...]
> > +       au2: analog-amplifier {
> > +               compatible = "simple-audio-amplifier";
> > +               sound-name-prefix = "AU2";
> > +               VCC-supply = <&vcc_5v>;
> > +               enable-gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
> > +       };
> I couldn't find any pictures online that show an analog audio output
> (typically a 3.5mm socket).
> Can you confirm that this is really present?
>
> [...]
> > +       sound {
> > +               compatible = "amlogic,gx-sound-card";
> > +               model = "XIAOMI-AQUAMAN";
> > +               audio-aux-devs = <&au2>;
> > +               audio-widgets = "Line", "Lineout";
> > +               audio-routing = "AU2 INL", "ACODEC LOLN",
> > +                               "AU2 INR", "ACODEC LORN",
> > +                               "Lineout", "AU2 OUTL",
> > +                               "Lineout", "AU2 OUTR";
> If there's no analog audio in/out then this section can be cleaned up
> as well - together with the references to acodec in the dai-links
> below.
>
> [...]
> > +/* Wireless SDIO Module (Amlogic W155S1 / Realtek RTL8821CS) */
> > +&sd_emmc_b {
> question to Neil: since we know that there's two board variants out
> there (with different wifi chipsets) - are dt overlays down the road
> enough (to enable Bluetooth / wifi - depending on the chipset or board
> revision) or do we need to split the whole .dts?

Perhaps yes

Neil

> Best regards,
> Martin