Re: [PATCH v1 1/3] arm64: defconfig: enable PCI Power Control for PCIe3

[Wenbin Yao (Consultant)]

On 3/21/2025 5:43 PM, Bartosz Golaszewski wrote:
> On Fri, Mar 21, 2025 at 8:37 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > On 20/03/2025 06:55, Wenbin Yao wrote:
> > > From: Qiang Yu <quic_qianyu@xxxxxxxxxxx>
> > >
> > > Enable the pwrctrl driver, which is utilized to manage the power supplies
> > > of the devices connected to the PCI slots. This ensures that the voltage
> > > rails of the x8 PCI slots on the X1E80100 - QCP can be correctly turned
> > > on/off if they are described under PCIe port device tree node.
> > >
> > > Signed-off-by: Qiang Yu <quic_qianyu@xxxxxxxxxxx>
> > > Signed-off-by: Wenbin Yao <quic_wenbyao@xxxxxxxxxxx>
> > > ---
> > >   arch/arm64/configs/defconfig | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > index 85ec2fba1..de86d1121 100644
> > > --- a/arch/arm64/configs/defconfig
> > > +++ b/arch/arm64/configs/defconfig
> > > @@ -245,6 +245,7 @@ CONFIG_PCIE_LAYERSCAPE_GEN4=y
> > >   CONFIG_PCI_ENDPOINT=y
> > >   CONFIG_PCI_ENDPOINT_CONFIGFS=y
> > >   CONFIG_PCI_EPF_TEST=m
> > > +CONFIG_PCI_PWRCTL_SLOT=y
> > Bartosz,
> >
> > Wasn't the intention to select it the same way as PCI_PWRCTL_PWRSEQ is
> > selected?
> >
> > Best regards,
> > Krzysztof
> For sure. I would expect there to be something like:
>
> select PCI_PWRCTL_SLOT if ARCH_QCOM
>
> in Kconfig and nothing in defconfig.
>
> Bartosz

IIUC, pci slot power driver is a common driver that could be used by all DT
based platform.

--
With best wishes
Wenbin