Re: [PATCH v8 2/4] rust: rename AlwaysRefCounted to RefCounted
From: Oliver Mangold
Date: Mon Mar 24 2025 - 03:32:29 EST
On 250321 0920, Boqun Feng wrote:
> On Thu, Mar 13, 2025 at 07:00:11AM +0000, Oliver Mangold wrote:
> > AlwaysRefCounted will become a marker trait to indicate that it is allowed
> > to obtain an ARef from a `&`, which cannot be allowed for types which are
> > also Ownable.
> >
>
> This commit log doesn't explain why we need to do this.
Hi Boqun,
what exactly do you have in mind? It mentions that it is to allow types that
are both Ownable and RefCounted. That the next step is to introduce
OwnableRefCounted? That we want to safely convert from ARef to Owned?
> > +
> > +// SAFETY: we currently do not implement `Ownable`, thus it is okay to can obtain an `ARef<Request>`
>
> s/we/We
>
Missed that one. Thanks.
Best regards,
Oliver