Re: [PATCH v6 6/6] arm64: dts: qcom: ipq5018: Enable PCIe

[George Moussalem]

On 3/21/25 18:13, Dmitry Baryshkov wrote:
> On Fri, Mar 21, 2025 at 04:14:44PM +0400, George Moussalem via B4 Relay wrote:
> > From: Nitheesh Sekar <quic_nsekar@xxxxxxxxxxx>
> >
> > Enable the PCIe controller and PHY nodes for RDP 432-c2.
> >
> > Signed-off-by: Nitheesh Sekar <quic_nsekar@xxxxxxxxxxx>
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> > Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 40 ++++++++++++++++++++++++++
> >   1 file changed, 40 insertions(+)
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>
> Minor question below.
>
> > +
> > +&pcie0_phy {
> > +	status = "okay";
>
> If you have schematics, are you sure that there are no supplies for the
> PCIe PHY / PCIe PLLs on this board?

I don't have the schematics, but none of the boards I've personally 
tested (mostly Linksys devices) require any supply. I've also checked 
the downstream board files documented on codelinaro for ipq5018, and 
none mention a supply.

> > +};
> > +
> >   &sdhc_1 {
> >   	pinctrl-0 = <&sdc_default_state>;
> >   	pinctrl-names = "default";

Best regards,
George