RE: [EXTERNAL] [PATCH net-next] octeontx2-af: mcs: Remove redundant 'flush_workqueue()' calls

[Geethasowjanya Akula]

>-----Original Message-----
>From: Chen Ni <nichen@xxxxxxxxxxx>
>Sent: Monday, March 24, 2025 1:39 PM
>To: Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Linu Cherian
><lcherian@xxxxxxxxxxx>; Geethasowjanya Akula <gakula@xxxxxxxxxxx>; Jerin
>Jacob <jerinj@xxxxxxxxxxx>; Hariprasad Kelam <hkelam@xxxxxxxxxxx>;
>Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>; andrew+netdev@xxxxxxx;
>davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
>pabeni@xxxxxxxxxx
>Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Chen Ni
><nichen@xxxxxxxxxxx>
>Subject: [EXTERNAL] [PATCH net-next] octeontx2-af: mcs: Remove redundant
>'flush_workqueue()' calls
>
>'destroy_workqueue()' already drains the queue before destroying it, so there is
>no need to flush it explicitly.
>
>Remove the redundant 'flush_workqueue()' calls.
>
>This was generated with coccinelle:
>
>@@
>expression E;
>@@
>
>- flush_workqueue(E);
>  destroy_workqueue(E);
>
>Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
>---
> drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
>b/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
>index d39d86e694cc..655dd4726d36 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs_rvu_if.c
>@@ -925,7 +925,6 @@ void rvu_mcs_exit(struct rvu *rvu)
> 	if (!rvu->mcs_intr_wq)
> 		return;
>
>-	flush_workqueue(rvu->mcs_intr_wq);
> 	destroy_workqueue(rvu->mcs_intr_wq);
> 	rvu->mcs_intr_wq = NULL;
> }
>--
>2.25.1
Thanks for the fix.
Reviewed-by: Geetha sowjanya <gakula@xxxxxxxxxxx>