Re: [Intel-wired-lan] [PATCH iwl-next v4] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

From: Avigail Dahan
Date: Mon Mar 24 2025 - 04:36:31 EST




On 22/02/2025 14:46, Piotr Wejman wrote:
Update the driver to use the new hardware timestamping API added in commit
66f7223039c0 ("net: add NDOs for configuring hardware timestamping").
Use Netlink extack for error reporting in e1000e_config_hwtstamp.
Align the indentation of net_device_ops.

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
Reviewed-by: Vitaly Lifshits <vitaly.lifshits@xxxxxxxxx>
Signed-off-by: Piotr Wejman <wejmanpm@xxxxxxxxx>
---
Changes in v4:
- fix line wrappnig
- Linke to v3: https://lore.kernel.org/netdev/20250216155729.63862-1-wejmanpm@xxxxxxxxx/

Changes in v3:
- remove new lines at the end of the extack
- add error print in e1000e_systim_reset
- Link to v2: https://lore.kernel.org/netdev/20250208154350.75316-1-wejmanpm@xxxxxxxxx/

Changes in v2:
- amend commit message
- use extack for error reporting
- rename e1000_mii_ioctl to e1000_ioctl
- Link to v1: https://lore.kernel.org/netdev/20250202170839.47375-1-piotrwejman90@xxxxxxxxx/

drivers/net/ethernet/intel/e1000e/e1000.h | 2 +-
drivers/net/ethernet/intel/e1000e/netdev.c | 75 +++++++++++-----------
2 files changed, 38 insertions(+), 39 deletions(-)

Tested-by: Avigail Dahan <avigailx.dahan@xxxxxxxxx>