Re: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI

[Wolfram Sang]

> +config SERIAL_RZ_SCI

I think this name is too generic. Most RZ-variants so far do not have
this SoC. Would 'RZT2H' work or is it too narrow then?

> +	SCIx_RZT2H_SCI_REGTYPE,

This name is better.

>  struct plat_sci_port {
> -	unsigned int	type;			/* SCI / SCIF / IRDA / HSCIF */
> +	unsigned int	type;			/* SCI / SCIF / IRDA / HSCIF / RZSCI */

"RZT2" in the comment as well.

> +/* SH-SCI */
> +#define PORT_RZSCI	124
> +
>  /* Generic type identifier for ports which type is not important to userspace. */
>  #define PORT_GENERIC	(-1)

Does userspace need to know this port? Can't we use PORT_GENERIC?

Attachment: signature.asc
Description: PGP signature