Re: [PATCH RFC] ufs: delegate the interrupt service routine to a threaded irq handler

From: Bart Van Assche
Date: Mon Mar 24 2025 - 07:02:47 EST


On 3/24/25 5:31 AM, Neil Armstrong wrote:
On 21/03/2025 17:20, Bart Van Assche wrote:
- Instead of retaining hba->ufs_stats.last_intr_status and
   hba->ufs_stats.last_intr_ts, please remove both members and also
   the debug code that reports the values of these member variables.
   Please also remove hba->intr_en.

Hmm ok so no need for the IRQ debug code anymore ? I guess this should
be in a separate cleanup patch.

Hi Neil,

There are two reasons why I propose to remove that code:
- I don't think that it is possible to keep that code and switch to
threaded interrupts without a measurable negative performance impact.
- That debug code is primarily useful for hardware (SoC) debugging,
something that falls outside the scope of the UFS driver.

Thanks,

Bart.