Re: [PATCH v7 2/5] bits: introduce fixed-type BIT_U*()

From: Andy Shevchenko
Date: Mon Mar 24 2025 - 09:42:39 EST


On Sat, Mar 22, 2025 at 06:23:13PM +0900, Vincent Mailhol via B4 Relay wrote:
> From: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
>
> Implement fixed-type BIT_U*() to help drivers add stricter checks,
> like it was done for GENMASK_U*().

...

> +/*
> + * Fixed-type variants of BIT(), with additional checks like GENMASK_TYPE(). The
> + * following examples generate compiler warnings due to shift-count-overflow:

"...due to -Wshift-count-overflow:" ?

Same idea — if you need a new version, since it's just a nit-pick.

> + *
> + * - BIT_U8(8)
> + * - BIT_U32(-1)
> + * - BIT_U32(40)
> + */

--
With Best Regards,
Andy Shevchenko