Re: [PATCH 03/18] dt-bindings: media: coda: Fix resets count
From: Krzysztof Kozlowski
Date: Mon Mar 24 2025 - 09:55:09 EST
On 24/03/2025 14:46, Sergey Khimich wrote:
>>> diff --git a/Documentation/devicetree/bindings/media/coda.yaml
>> b/Documentation/devicetree/bindings/media/coda.yaml
>>> index c9d5adbc8c4a..3cb0e9afc100 100644
>>> --- a/Documentation/devicetree/bindings/media/coda.yaml
>>> +++ b/Documentation/devicetree/bindings/media/coda.yaml
>>> @@ -60,7 +60,7 @@ properties:
>>> maxItems: 1
>>>
>>> resets:
>>> - maxItems: 1
>>> + minItems: 1
>>
>> No, this must be specific.
>>
> Here I can suggest the following patch with adding standalone (without a
> SoC-specific fallback) definition of coda980 codec:
How can it be used outside of soc?
>
> @@ -30,6 +30,8 @@ properties:
> - fsl,imx6dl-vpu
> - fsl,imx6q-vpu
> - const: cnm,coda960
> + - items:
> + - const: cnm,coda980
>
> reg:
> maxItems: 1
> @@ -60,7 +62,15 @@ properties:
> maxItems: 1
>
> resets:
> - maxItems: 1
> + if:
There is no such syntax - see other files or example-schema.
> + properties:
> + compatible:
> + contains:
> + const: cnm,coda980
> + then:
> + maxItems: 2 # CODA980 supports 2 resets
Still not specific - you need to list the items. See other files.
Best regards,
Krzysztof