Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: add lt3074

From: Guenter Roeck
Date: Mon Mar 24 2025 - 09:59:00 EST


On 3/24/25 00:16, Krzysztof Kozlowski wrote:
On 21/03/2025 18:24, Guenter Roeck wrote:

Figured. As it turns out, there is also a patch series pending which tries
to fix the problem for ir38060 by changing its bindings.

I'll dig up my patch series to add a new macro and send it out as RFT.


Question for DT maintainers:

Existing bindings, such as
Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml
expect a nested regulators node even though there is only a single
regulator. What is the correct approach: Keep the nesting requirement
for those regulators as is (even if there are no in-tree bindings
using them), or update the code and the bindings to drop the nesting ?

I would recommend keep the nesting, so don't touch it. There might be
external users, other projects relying on this. You can however
deprecate old node (nesting), if the driver can support both. Not sure
if it is worth the effort.

That is not in driver control: If regulators_node is set by the driver,
the regulator subsystem mandates the sub-node.

Thanks,
Guenter